Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the handling of CodeDomain types in the pivot table #615

Merged
merged 9 commits into from
Feb 19, 2024

Conversation

Iyedchaabane
Copy link
Contributor

APPS-01X0 : Correct the handling of CodeDomain types in the pivot table

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'ordre des imports
supprimer cette ligne : format: VCellFormat?
supprimer l'affectation du l'attribut format au class VBooleanCodeColumn, VDecimalCodeColumn, VIntegerCodeColumn et VStringCodeColumn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supprimer l'attribut : format: VCellFormat?
supprimer l'affectation du l'attribut format au class VBooleanColumn, VDecimalColumn, VIntegerColumn et VStringColumn
Ajouter les class VDateColumn, VMonthColumn, VWeekColumn, VTimeColumn et VTimestampColumn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprimer les imports suivants :
import org.kopi.galite.visual.dsl.common.Trigger
import org.kopi.galite.visual.report.VCellFormat

supprimer le variable : formatTrigger
supprimer le variable format ligne 43
Changer la méthode buildPivotTableFieldModel(this, position,format) à buildPivotTableFieldModel(this, position)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprimer les imports suivants :
import org.kopi.galite.visual.dsl.common.Trigger
import org.kopi.galite.visual.report.VCellFormat

supprimer le variable : formatTrigger
supprimer le variable format ligne 41
Changer la méthode buildPivotTableFieldModel(this, Dimension.Position.NONE,format) à buildPivotTableFieldModel(this, Dimension.Position.NONE)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restaurer la ligne 34 : internal var userRows: ArrayList? = ArrayList()
et faire les changements nécessaires

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supprimer cette import : import org.kopi.galite.visual.report.VCellFormat
supprimer cette ligne format: VCellFormat? ( ligne 8 )
supprimer ligne 11
supprimer les sauts de ligne ( ligne 12 et 13 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supprimer cette import : import org.kopi.galite.visual.report.VCellFormat
supprimer ligne 30
supprimer cette ligne format: VCellFormat? ( ligne 34 )
vérifier l'utilisation du méthode format
A quoi sert le changement du méthode localize à open

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Par analogie avec VReportColumn, j'ajoute une nouvelle méthode ouverte nommée localize(parentLocalizer: FieldLocalizer) avec un corps vide. Cette dernière sera utilisée dans VCodeColumn .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supprimer cette import : import org.kopi.galite.visual.report.VCellFormat
supprimer cette ligne format: VCellFormat? ( ligne 12 )
supprimer ligne 18

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supprimer cette import : import org.kopi.galite.visual.report.VCellFormat
supprimer cette ligne format: VCellFormat? ( ligne 13 )
supprimer ligne 16
supprimer le saut de ligne ( ligne 17 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changer le nom du variable baseRows,
Changer le nom du fonction changeValue
Changer le nom du variable i par j et la variable j par i.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprimer le saut de ligne ( ligne 46 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'indentation :
: VCodeColumn(ident,
position,
type,
source,
name) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changer ces deux lignes :

  • Copyright (c) 2013-2022 kopiLeft Services SARL, Tunis TN
  • Copyright (c) 1990-2022 kopiRight Managed Solutions GmbH, Wien AT

2022 --> 2023

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changer ces deux lignes :

  • Copyright (c) 2013-2022 kopiLeft Services SARL, Tunis TN
  • Copyright (c) 1990-2022 kopiRight Managed Solutions GmbH, Wien AT

2022 --> 2023

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger l'indentation :
: VCodeColumn(ident,
position,
type,
source,
name) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supprimer le saut de ligne ( ligne 46 )

@mgrati mgrati merged commit 3a8af11 into master Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants